fix(consensus)!: state change on foreign proposals in local blocks #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI)553 tests ±0 552 ✅ ±0 1h 49m 10s ⏱️ - 28m 52s For more details on these failures, see this check. Results for commit 66ff95e. ± Comparison against base commit b3f1507. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
sdbondi
force-pushed
the
consensus-foreign-proposal-counts
branch
from
70ef642 to
66ff95e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Propose foreign proposals before associated transaction pending state changes occur.
Evidence structure now holds a QC ID for prepare and accept phases for each substate.
Indexer will submit transactions to two validators instead of just one.
Remove unused
should_propagateoption from the mempool.Motivation and Context
Previously foreign proposals would appear after the transaction that they justify.
Foreign proposals should be proposed and the transaction stage transactions included in the change set for the block.
How Has This Been Tested?
Existing tests, manually
What process can a PR reviewer use to test or verify this change?
Observe blocks contain foreign proposals that affect LocalPrepare and LocalAccept pledging at or before the actual stage transaction is proposed.
Breaking Changes